Skip to content

Comments

CAM-SIMA diagnostics for all gravity wave parameterizations#338

Open
jimmielin wants to merge 6 commits intoESCOMP:developmentfrom
jimmielin:hplin/gw_drag_diags
Open

CAM-SIMA diagnostics for all gravity wave parameterizations#338
jimmielin wants to merge 6 commits intoESCOMP:developmentfrom
jimmielin:hplin/gw_drag_diags

Conversation

@jimmielin
Copy link
Member

@jimmielin jimmielin commented Dec 5, 2025 •
edited
Loading

Originator(s): @jimmielin

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

  • Add diagnostics (parity with CAM) for gravity wave parameterizations in CAM-SIMA.

List all namelist files that were added or changed: N/A

List all files eliminated and why: N/A

List all files added and what they do:

A       schemes/sima_diagnostics/gravity_wave_drag_convection_deep_diagnostics.F90
A       schemes/sima_diagnostics/gravity_wave_drag_convection_deep_diagnostics.meta
A       schemes/sima_diagnostics/gravity_wave_drag_frontogenesis_diagnostics.F90
A       schemes/sima_diagnostics/gravity_wave_drag_frontogenesis_diagnostics.meta
A       schemes/sima_diagnostics/gravity_wave_drag_moving_mountain_diagnostics.F90
A       schemes/sima_diagnostics/gravity_wave_drag_moving_mountain_diagnostics.meta
A       schemes/sima_diagnostics/gravity_wave_drag_orographic_diagnostics.F90
A       schemes/sima_diagnostics/gravity_wave_drag_orographic_diagnostics.meta
A       schemes/sima_diagnostics/gravity_wave_drag_ridge_beta_diagnostics.F90
A       schemes/sima_diagnostics/gravity_wave_drag_ridge_beta_diagnostics.meta
  - various diagnostic schemes for various gravity wave drag parameterizations.

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       schemes/gravity_wave_drag/gravity_wave_drag_convection.meta
M       schemes/gravity_wave_drag/gravity_wave_drag_frontogenesis.F90
M       schemes/gravity_wave_drag/gravity_wave_drag_frontogenesis.meta
M       schemes/gravity_wave_drag/gravity_wave_drag_moving_mountain.meta
M       schemes/gravity_wave_drag/gravity_wave_drag_orographic.F90
M       schemes/gravity_wave_drag/gravity_wave_drag_orographic.meta
  - fix issues with temperature tendencies/dry air enthalpy tendency units throughout.
  - fix incorrectly annotated hdepth (m not km) units

M       schemes/sima_diagnostics/gravity_wave_drag_common_diagnostics.F90
M       schemes/sima_diagnostics/gravity_wave_drag_common_diagnostics.meta
  - populate the remaining common gravity wave drag diagnostics (TTGW,UTGW_TOTAL,VTGW_TOTAL,QTGW,CLDLIQTGW,CLDICETGW)

M       suites/suite_cam4.xml
M       suites/suite_cam7.xml
M       test/test_suites/suite_gw_cam4.xml
M       test/test_suites/suite_gw_cam7_se.xml
  - call diagnostic schemes in SDFs

List all automated tests that failed, as well as an explanation for why they weren't fixed:
New baselines will be created in the eventual CAM-SIMA PR

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
New diagnostic fields
Model "state" is b4b

If yes to the above question, describe how this code was validated with the new/modified features:

@jimmielin jimmielin self-assigned this Dec 5, 2025
@jimmielin jimmielin added enhancement New feature or request CAM4 CAM-SIMA tuning labels Dec 5, 2025
@nusbaume nusbaume requested review from nusbaume and removed request for nusbaume December 17, 2025 18:01
@jimmielin jimmielin requested a review from nusbaume January 5, 2026 17:09
nusbaume
nusbaume requested changes Jan 22, 2026
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing in these diagnostics @jimmielin! I did have some some questions/concerns, mostly related to standard names and/or units, but of course if any of them are too much of a burden at this stage then we can likely just make an issue for it and deal with them later. Thanks again!

@jimmielin jimmielin requested a review from nusbaume January 22, 2026 15:00
@jimmielin
Copy link
Member Author

jimmielin commented Jan 22, 2026

Thanks @nusbaume for the review! I edited some standard names throughout the GW parameterizations in particular to address concerns about the use of tendency_of_air_temperature_ when it is dry air enthalpy tendency - my apologies that the scope of the PR increased a little but hopefully it should be a coherent set of changes to review.

nusbaume
nusbaume approved these changes Feb 10, 2026
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thoroughly checking and modifying all of the units and standard names @jimmielin! I just had one last comment update request, but otherwise this all looks good to me!

schemes/gravity_wave_drag/gravity_wave_drag_frontogenesis.F90 Outdated
real(kind_phys), intent(out) :: dttdf(:, :) ! Temperature tendency from diffusion [K s-1]
real(kind_phys), intent(out) :: dttke(:, :) ! Temperature tendency from kinetic energy dissipation [K s-1]
real(kind_phys), intent(out) :: dttdf(:, :) ! Dry air enthalpy tendency from diffusion [J kg-1 s-1]
real(kind_phys), intent(out) :: dttke(:, :) ! Dry air tendency from kinetic energy dissipation [J kg-1 s-1]
Copy link
Collaborator

@nusbaume nusbaume Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think enthalpy is missing from the comment here for dttke?

Copy link
Member Author

@jimmielin jimmielin Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated! There were a few others I missed looking back so d357db5 addresses all these.

@nusbaume nusbaume requested a review from peverwhee February 10, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nusbaume nusbaume nusbaume approved these changes

@peverwhee peverwhee Awaiting requested review from peverwhee

At least 2 approving reviews are required to merge this pull request.

Assignees

@jimmielin jimmielin

Labels

CAM4 CAM-SIMA tuning enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmielin @nusbaume